Update CTA #5627
Merged
Update CTA #5627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinTurska
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
the
Playground
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5627 +/- ##
=======================================
Coverage 50.63% 50.63%
=======================================
Files 1091 1091
Lines 57100 57100
Branches 4589 4589
=======================================
Hits 28914 28914
Misses 27470 27470
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
joaquim-verges
approved these changes
Dec 5, 2024
gregfromstl
added
the
merge-queue
Contributor
Merge activity
|
gregfromstl
pushed a commit
that referenced
this pull request
Dec 8, 2024
Set CTA for Engine Playground to "Deploy an Instance" ## Problem solved Update for [DASH-535](https://linear.app/thirdweb/issue/DASH-535/make-deploy-an-instance-the-primary-cta-in-playground) Set CTA for Engine Playground to "Deploy an Instance" <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on adding `deployLink` properties to various pages and updating the `EngineAPIHeader` component to include a dynamic link for deploying instances. ### Detailed summary - Added `deployLink` to `webhooks`, `minting`, and `airdrop` pages. - Updated `EngineAPIHeader` component to include a button linking to `deployLink`. - Removed hardcoded deploy link from the `EngineAPIHeader`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
dustin/playground_updates
branch
from
39a1436 to
6b246d1
Compare
Set CTA for Engine Playground to "Deploy an Instance" ## Problem solved Update for [DASH-535](https://linear.app/thirdweb/issue/DASH-535/make-deploy-an-instance-the-primary-cta-in-playground) Set CTA for Engine Playground to "Deploy an Instance" <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily updates the `deployLink` across multiple pages and modifies the `EngineAPIHeader` component to dynamically include the `deployLink` prop, enhancing the deployment functionality in the playground web application. ### Detailed summary - Added `deployLink` prop to `page.tsx` files for `webhooks`, `minting`, and `airdrop`. - Updated `docsLink` for `minting` and `airdrop` pages to point to specific API documentation. - Modified `EngineAPIHeader` component to utilize the `deployLink` prop for dynamic linking. - Removed hardcoded `Deploy an Instance` button from `EngineAPIHeader`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
dustin/playground_updates
branch
from
6b246d1 to
015293e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set CTA for Engine Playground to "Deploy an Instance"
Problem solved
Update for DASH-535
Set CTA for Engine Playground to "Deploy an Instance"
PR-Codex overview
This PR focuses on adding
deployLinkproperties and corresponding links to various pages in theplayground-webapplication, enhancing user navigation to deployment and documentation resources.Detailed summary
deployLinktopage.tsxfiles forwebhooks,minting, andairdropsections.EngineAPIHeadercomponent to include a newdeployLinkprop.Deploy an Instancebutton fromEngineAPIHeaderand replaced it with a dynamic link usingprops.deployLink.